lxm_library_java/WxJava
1
0
Fork 0
mirror of synced 2026-02-07 19:27:50 +08:00
Code Issues Projects Releases Wiki Activity

重构测试代码以消除重复逻辑

Browse Source 
Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2026-01-27 03:04:46 +00:00
parent 6a678d1901
commit 1eeb41d475
1 changed files with 20 additions and 8 deletions
Download Patch File Download Diff File Expand all files Collapse all files

28
weixin-java-cp/src/test/java/me/chanjar/weixin/cp/api/impl/WxCpServiceGetMsgAuditAccessTokenTest.java
View File

@@ -96,6 +96,22 @@ public class WxCpServiceGetMsgAuditAccessTokenTest {
}
}
/**
* 检查token是否需要刷新的公共逻辑
*/
private boolean shouldRefreshToken(WxCpConfigStorage storage, boolean forceRefresh) {
return storage.isMsgAuditAccessTokenExpired() || forceRefresh;
}
/**
* 验证会话存档secret是否已配置的公共逻辑
*/
private void validateMsgAuditSecret(String msgAuditSecret) throws WxErrorException {
if (msgAuditSecret == null || msgAuditSecret.trim().isEmpty()) {
throw new WxErrorException("会话存档secret未配置");
}
}
/**
* 创建一个用于测试的BaseWxCpServiceImpl实现，
* 用于测试缓存和过期逻辑
@@ -125,15 +141,13 @@ public class WxCpServiceGetMsgAuditAccessTokenTest {
@Override
public String getMsgAuditAccessToken(boolean forceRefresh) throws WxErrorException {
// 检查是否需要刷新
if (!getWxCpConfigStorage().isMsgAuditAccessTokenExpired() && !forceRefresh) {
if (!shouldRefreshToken(getWxCpConfigStorage(), forceRefresh)) {
return getWxCpConfigStorage().getMsgAuditAccessToken();
}
// 使用会话存档secret获取access_token
String msgAuditSecret = getWxCpConfigStorage().getMsgAuditSecret();
if (msgAuditSecret == null || msgAuditSecret.trim().isEmpty()) {
throw new WxErrorException("会话存档secret未配置");
}
validateMsgAuditSecret(msgAuditSecret);
// 返回缓存的token（用于测试缓存机制）
return getWxCpConfigStorage().getMsgAuditAccessToken();
@@ -183,15 +197,13 @@ public class WxCpServiceGetMsgAuditAccessTokenTest {
lock.lock();
try {
// 检查是否需要刷新
if (!getWxCpConfigStorage().isMsgAuditAccessTokenExpired() && !forceRefresh) {
if (!shouldRefreshToken(getWxCpConfigStorage(), forceRefresh)) {
return getWxCpConfigStorage().getMsgAuditAccessToken();
}
// 使用会话存档secret获取access_token
String msgAuditSecret = getWxCpConfigStorage().getMsgAuditSecret();
if (msgAuditSecret == null || msgAuditSecret.trim().isEmpty()) {
throw new WxErrorException("会话存档secret未配置");
}
validateMsgAuditSecret(msgAuditSecret);
// 模拟获取新token并更新配置
getWxCpConfigStorage().updateMsgAuditAccessToken(mockToken, 7200);