From 228bd49352a74ad27f22ab7d638697adfc80a419 Mon Sep 17 00:00:00 2001 From: aimil Date: Tue, 20 Sep 2016 16:15:40 +0800 Subject: [PATCH 1/2] =?UTF-8?q?=E5=88=9B=E5=BB=BA=E8=8F=9C=E5=8D=95?= =?UTF-8?q?=E6=97=B6=E6=B7=BB=E5=8A=A0=E6=97=A5=E5=BF=97=E8=AE=B0=E5=BD=95?= =?UTF-8?q?=E5=8A=9F=E8=83=BD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../mp/api/impl/WxMpMenuServiceImpl.java | 31 ++++++++++++++----- 1 file changed, 24 insertions(+), 7 deletions(-) diff --git a/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpMenuServiceImpl.java b/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpMenuServiceImpl.java index 28dbff912..a296fffdb 100644 --- a/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpMenuServiceImpl.java +++ b/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpMenuServiceImpl.java @@ -1,5 +1,8 @@ package me.chanjar.weixin.mp.api.impl; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; + import me.chanjar.weixin.common.bean.menu.WxMenu; import me.chanjar.weixin.common.exception.WxErrorException; import me.chanjar.weixin.common.util.http.SimpleGetRequestExecutor; @@ -12,6 +15,7 @@ import me.chanjar.weixin.mp.api.WxMpService; */ public class WxMpMenuServiceImpl implements WxMpMenuService { private static final String API_URL_PREFIX = "https://api.weixin.qq.com/cgi-bin/menu"; + private static Logger log = LoggerFactory.getLogger(WxMpMenuServiceImpl.class); private WxMpService wxMpService; @@ -21,25 +25,38 @@ public class WxMpMenuServiceImpl implements WxMpMenuService { @Override public void menuCreate(WxMenu menu) throws WxErrorException { + String menuJson = menu.toJson(); + String url = API_URL_PREFIX + "/create"; if (menu.getMatchRule() != null) { - String url = API_URL_PREFIX + "/addconditional"; - this.wxMpService.execute(new SimplePostRequestExecutor(), url, menu.toJson()); - } else { - String url = API_URL_PREFIX + "/create"; - this.wxMpService.execute(new SimplePostRequestExecutor(), url, menu.toJson()); + url = API_URL_PREFIX + "/addconditional"; + } + if(log.isTraceEnabled()){ + log.trace("开始创建菜单：{}", menuJson); + } + + String result = this.wxMpService.execute(new SimplePostRequestExecutor(), url,menuJson); + + if(log.isDebugEnabled()){ + log.debug("创建菜单：{},结果：{}", menuJson, result); } } @Override public void menuDelete() throws WxErrorException { String url = API_URL_PREFIX + "/delete"; - this.wxMpService.execute(new SimpleGetRequestExecutor(), url, null); + String result = this.wxMpService.execute(new SimpleGetRequestExecutor(), url, null); + if(log.isDebugEnabled()){ + log.debug("删除菜单结果：{}", result); + } } @Override public void menuDelete(String menuid) throws WxErrorException { String url = API_URL_PREFIX + "/delconditional"; - this.wxMpService.execute(new SimpleGetRequestExecutor(), url, "menuid=" + menuid); + String result = this.wxMpService.execute(new SimpleGetRequestExecutor(), url, "menuid=" + menuid); + if(log.isDebugEnabled()){ + log.debug("根据MeunId({})删除菜单结果：{}", menuid,result); + } } @Override From b98661b24ca4f7f1d282017badadc5f0cd37a065 Mon Sep 17 00:00:00 2001 From: aimil Date: Wed, 21 Sep 2016 14:52:21 +0800 Subject: [PATCH 2/2] =?UTF-8?q?=E5=88=A0=E9=99=A4=E5=A4=9A=E4=BD=99?= =?UTF-8?q?=E5=88=A4=E6=96=AD?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- .../weixin/mp/api/impl/WxMpMenuServiceImpl.java | 17 ++++------------- 1 file changed, 4 insertions(+), 13 deletions(-) diff --git a/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpMenuServiceImpl.java b/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpMenuServiceImpl.java index a296fffdb..ac34cdbf8 100644 --- a/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpMenuServiceImpl.java +++ b/weixin-java-mp/src/main/java/me/chanjar/weixin/mp/api/impl/WxMpMenuServiceImpl.java @@ -30,33 +30,24 @@ public class WxMpMenuServiceImpl implements WxMpMenuService { if (menu.getMatchRule() != null) { url = API_URL_PREFIX + "/addconditional"; } - if(log.isTraceEnabled()){ - log.trace("开始创建菜单：{}", menuJson); - } + log.trace("开始创建菜单：{}", menuJson); String result = this.wxMpService.execute(new SimplePostRequestExecutor(), url,menuJson); - - if(log.isDebugEnabled()){ - log.debug("创建菜单：{},结果：{}", menuJson, result); - } + log.debug("创建菜单：{},结果：{}", menuJson, result); } @Override public void menuDelete() throws WxErrorException { String url = API_URL_PREFIX + "/delete"; String result = this.wxMpService.execute(new SimpleGetRequestExecutor(), url, null); - if(log.isDebugEnabled()){ - log.debug("删除菜单结果：{}", result); - } + log.debug("删除菜单结果：{}", result); } @Override public void menuDelete(String menuid) throws WxErrorException { String url = API_URL_PREFIX + "/delconditional"; String result = this.wxMpService.execute(new SimpleGetRequestExecutor(), url, "menuid=" + menuid); - if(log.isDebugEnabled()){ - log.debug("根据MeunId({})删除菜单结果：{}", menuid,result); - } + log.debug("根据MeunId({})删除菜单结果：{}", menuid,result); } @Override